From e6f4df3442761d24b6052eb0d4debe503c0a7606 Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Fri, 31 Jan 2025 12:11:59 -0500 Subject: [PATCH] Prioritize coalescing parameters in Moderation\Users\*->processGetActions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ↪ This was causing missing array index warnings when the casting took precedence --- src/Module/Moderation/Users/Active.php | 4 ++-- src/Module/Moderation/Users/Blocked.php | 4 ++-- src/Module/Moderation/Users/Index.php | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Module/Moderation/Users/Active.php b/src/Module/Moderation/Users/Active.php index 1b11685f64..a91f5934dc 100644 --- a/src/Module/Moderation/Users/Active.php +++ b/src/Module/Moderation/Users/Active.php @@ -124,8 +124,8 @@ class Active extends BaseUsers */ private function processGetActions(): void { - $action = (string)$this->parameters['action'] ?? ''; - $uid = (int)$this->parameters['uid'] ?? 0; + $action = (string) ($this->parameters['action'] ?? ''); + $uid = (int) ($this->parameters['uid'] ?? 0); if ($uid === 0) { return; diff --git a/src/Module/Moderation/Users/Blocked.php b/src/Module/Moderation/Users/Blocked.php index fbdbc8d8c7..3c2577f7f0 100644 --- a/src/Module/Moderation/Users/Blocked.php +++ b/src/Module/Moderation/Users/Blocked.php @@ -123,8 +123,8 @@ class Blocked extends BaseUsers */ private function processGetActions(): void { - $action = (string)$this->parameters['action'] ?? ''; - $uid = (int)$this->parameters['uid'] ?? 0; + $action = (string) ($this->parameters['action'] ?? ''); + $uid = (int) ($this->parameters['uid'] ?? 0); if ($uid === 0) { return; diff --git a/src/Module/Moderation/Users/Index.php b/src/Module/Moderation/Users/Index.php index 7d195c1096..26d71efd60 100644 --- a/src/Module/Moderation/Users/Index.php +++ b/src/Module/Moderation/Users/Index.php @@ -135,8 +135,8 @@ class Index extends BaseUsers */ private function processGetActions(): void { - $action = (string) $this->parameters['action'] ?? ''; - $uid = (int) $this->parameters['uid'] ?? 0; + $action = (string) ($this->parameters['action'] ?? ''); + $uid = (int) ($this->parameters['uid'] ?? 0); if ($uid === 0) { return;