More usage of dbm::is_result($r) instead of count($r):

- count() returns very different results and never a boolean (not even false on
  error condition).
- therefore you should NOT use it in boolean expressions. This still *can* be
  done in PHP because of its lazyness. But it is discouraged if it comes to
  more clean code.

Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
Roland Häder 2016-12-13 10:44:13 +01:00
parent 293436e5fd
commit 6a8a36f12d
115 changed files with 439 additions and 437 deletions

View file

@ -16,7 +16,7 @@ function viewcontacts_init(&$a) {
dbesc($nick)
);
if(! count($r))
if(! dbm::is_result($r))
return;
$a->data['user'] = $r[0];
@ -54,7 +54,7 @@ function viewcontacts_content(&$a) {
dbesc(NETWORK_DIASPORA),
dbesc(NETWORK_OSTATUS)
);
if(count($r))
if(dbm::is_result($r))
$a->set_pager_total($r[0]['total']);
$r = q("SELECT * FROM `contact`
@ -68,7 +68,7 @@ function viewcontacts_content(&$a) {
intval($a->pager['start']),
intval($a->pager['itemspage'])
);
if(!count($r)) {
if(!dbm::is_result($r)) {
info(t('No contacts.').EOL);
return $o;
}