oldkid/friendica
1
0
Fork 0
mirror of https://git.sekbaer.de/Friendica/friendica.git synced 2025-06-16 20:05:14 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

More usage of dbm::is_result($r) instead of count($r):

Browse source 
- count() returns very different results and never a boolean (not even false on
  error condition).
- therefore you should NOT use it in boolean expressions. This still *can* be
  done in PHP because of its lazyness. But it is discouraged if it comes to
  more clean code.

Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
Roland Häder 2016-12-13 10:44:13 +01:00
parent 293436e5fd
commit 6a8a36f12d
115 changed files with 439 additions and 437 deletions
Download patch file Download diff file Expand all files Collapse all files

6
mod/profile_photo.php
View file

@ -32,7 +32,7 @@ function profile_photo_post(&$a) {
intval($_REQUEST['profile']),
intval(local_user())
);
if(count($r) && (! intval($r[0]['is-default'])))
if(dbm::is_result($r) && (! intval($r[0]['is-default'])))
$is_default_profile = 0;
}
@ -63,7 +63,7 @@ function profile_photo_post(&$a) {
dbesc(local_user()),
intval($scale));
if(count($r)) {
if(dbm::is_result($r)) {
$base_image = $r[0];
@ -195,7 +195,7 @@ function profile_photo_content(&$a) {
intval(local_user()),
dbesc($resource_id)
);
if (!count($r)){
if (!dbm::is_result($r)){
notice( t('Permission denied.') . EOL );
return;
}