oldkid/friendica
1
0
Fork 0
mirror of https://git.sekbaer.de/Friendica/friendica.git synced 2025-06-08 00:04:27 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #14734 from MrPetovan/bug/empty-dom-string

Browse source 
Ward against empty string in Model\Item::replacePlatformIcon
This commit is contained in:
Michael Vogel 2025-01-26 22:45:43 +01:00 • committed by GitHub
commit 5a00a2c441
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/Model/Item.php
View file

@ -3498,6 +3498,10 @@ class Item
} }
if (!empty($shared_item['uri-id'])) { if (!empty($shared_item['uri-id'])) {
if (!$s) {
DI::logger()->notice('Unexpected empty item HTML', ['item' => $item]);
}
$s = self::replacePlatformIcon($s, $shared_item, $uid); $s = self::replacePlatformIcon($s, $shared_item, $uid);
} }
@ -3574,6 +3578,10 @@ class Item
*/ */
private static function replacePlatformIcon(string $html, array $item, int $uid): string private static function replacePlatformIcon(string $html, array $item, int $uid): string
{ {
if ($html === '') {
return $html;
}
$dom = new \DOMDocument(); $dom = new \DOMDocument();
if (!@$dom->loadHTML($html)) { if (!@$dom->loadHTML($html)) {
return $html; return $html;