From 432f28ecd1e730ba7a770564789f468c9abb7831 Mon Sep 17 00:00:00 2001
From: Art4 <art4@wlabs.de>
Date: Sun, 22 Dec 2024 14:29:13 +0000
Subject: [PATCH] merge code quality checks into on workflow

---
 .../{code-style.yml => code-quality.yml}      | 38 ++++++++++++++--
 .github/workflows/phpstan.yml                 | 44 -------------------
 2 files changed, 35 insertions(+), 47 deletions(-)
 rename .github/workflows/{code-style.yml => code-quality.yml} (54%)
 delete mode 100644 .github/workflows/phpstan.yml

diff --git a/.github/workflows/code-style.yml b/.github/workflows/code-quality.yml
similarity index 54%
rename from .github/workflows/code-style.yml
rename to .github/workflows/code-quality.yml
index d7bd23aaa3..dad0aec9e1 100644
--- a/.github/workflows/code-style.yml
+++ b/.github/workflows/code-quality.yml
@@ -2,7 +2,7 @@
 #
 # SPDX-License-Identifier: CC0-1.0
 
-name: Code Style
+name: Code Quality
 
 on:
   push:
@@ -11,7 +11,7 @@ on:
 
 jobs:
 
-  tests:
+  code-style:
     name: PHP-CS-Fixer (PHP ${{ matrix.php }})
     runs-on: ubuntu-latest
 
@@ -42,4 +42,36 @@ jobs:
 
       - name: Run PHP-CS-Fixer
         continue-on-error: true
-        run: bin/dev/php-cs-fixer/vendor/bin/php-cs-fixer fix --diff --dry-run
\ No newline at end of file
+        run: bin/dev/php-cs-fixer/vendor/bin/php-cs-fixer fix --diff --dry-run
+
+  phpstan:
+    name: PHPStan (PHP ${{ matrix.php }})
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        operating-system: ['ubuntu-latest']
+        php: ['8.4']
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 2
+
+      - name: Setup PHP with composer and extensions
+        uses: shivammathur/setup-php@v2 #https://github.com/shivammathur/setup-php
+        with:
+          php-version: ${{ matrix.php }}
+          coverage: xdebug
+          tools: none
+
+      - name: Clone addon repository
+        run: git clone -b develop --single-branch https://git.friendi.ca/friendica/friendica-addons.git addon
+
+      - name: Install Composer dependencies
+        uses: "ramsey/composer-install@v2"
+
+      - name: Run PHPStan
+        run: composer run phpstan
diff --git a/.github/workflows/phpstan.yml b/.github/workflows/phpstan.yml
deleted file mode 100644
index d3c94de7fd..0000000000
--- a/.github/workflows/phpstan.yml
+++ /dev/null
@@ -1,44 +0,0 @@
-# SPDX-FileCopyrightText: 2010 - 2024 the Friendica project
-#
-# SPDX-License-Identifier: CC0-1.0
-
-name: Static Code Analysis
-
-on:
-  push:
-  pull_request:
-  workflow_dispatch:
-
-jobs:
-
-  tests:
-    name: PHPStan (PHP ${{ matrix.php }})
-    runs-on: ubuntu-latest
-
-    strategy:
-      fail-fast: false
-      matrix:
-        operating-system: ['ubuntu-latest']
-        php: ['8.4']
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-        with:
-          fetch-depth: 2
-
-      - name: Setup PHP with composer and extensions
-        uses: shivammathur/setup-php@v2 #https://github.com/shivammathur/setup-php
-        with:
-          php-version: ${{ matrix.php }}
-          coverage: xdebug
-          tools: none
-
-      - name: Clone addon repository
-        run: git clone -b develop --single-branch https://git.friendi.ca/friendica/friendica-addons.git addon
-
-      - name: Install Composer dependencies
-        uses: "ramsey/composer-install@v2"
-
-      - name: Run PHPStan
-        run: composer run phpstan
\ No newline at end of file