More usage of dbm::is_result($r) instead of count($r):

- count() returns very different results and never a boolean (not even false on
  error condition).
- therefore you should NOT use it in boolean expressions. This still *can* be
  done in PHP because of its lazyness. But it is discouraged if it comes to
  more clean code.

Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
Roland Häder 2016-12-13 10:44:13 +01:00
parent 293436e5fd
commit 6a8a36f12d
115 changed files with 439 additions and 437 deletions

View file

@ -52,7 +52,7 @@ function poke_init(&$a) {
intval($uid)
);
if(! count($r)) {
if(! dbm::is_result($r)) {
logger('poke: no contact ' . $contact_id);
return;
}
@ -66,7 +66,7 @@ function poke_init(&$a) {
intval($parent),
intval($uid)
);
if(count($r)) {
if(dbm::is_result($r)) {
$parent_uri = $r[0]['uri'];
$private = $r[0]['private'];
$allow_cid = $r[0]['allow_cid'];
@ -159,7 +159,7 @@ function poke_content(&$a) {
intval($_GET['c']),
intval(local_user())
);
if(count($r)) {
if(dbm::is_result($r)) {
$name = $r[0]['name'];
$id = $r[0]['id'];
}