Change repository naming to avoid naming conflicts

src/Core/Cache/Type/DatabaseCache.php

@@ -11,6 +11,7 @@ use Friendica\Core\Cache\Capability\ICanCache;
 use Friendica\Core\Cache\Enum;
 use Friendica\Core\Cache\Exception\CachePersistenceException;
 use Friendica\Database\Database;
+use Friendica\DI;
 use Friendica\Repository\CacheRepository;
 use Friendica\Util\DateTimeFormat;
 
@@ -34,7 +35,8 @@ class DatabaseCache extends AbstractCache implements ICanCache
 
 		$this->dba = $dba;
 
-		$this->cacheRepo = new CacheRepository($dba);
+		// #TODO: Replace this with constuctor injection
+		$this->cacheRepo = DI::databaseService()->getCacheRepository();
 	}
 
 	/**

src/Database/DatabaseService.php

@@ -10,8 +10,10 @@ declare(strict_types=1);
 namespace Friendica\Database;
 
 use Friendica\Database\Database;
-use Friendica\Database\Repository\DeletedUserRepository;
+use Friendica\Database\Repository\CacheTableRepository;
-use Friendica\Repository\UserdRepository;
+use Friendica\Database\Repository\UserdTableRepository;
+use Friendica\Repository\CacheRepository;
+use Friendica\Repository\DeletedUserRepository;
 
 final class DatabaseService
 {
@@ -24,6 +26,11 @@ final class DatabaseService
 
 	public function getDeletedUserRepository(): DeletedUserRepository
 	{
-		return new UserdRepository($this->database);
+		return new UserdTableRepository($this->database);
+	}
+
+	public function getCacheRepository(): CacheRepository
+	{
+		return new CacheTableRepository($this->database);
 	}
 }

src/Database/Model/CacheModel.php

@@ -7,11 +7,11 @@
 
 declare(strict_types=1);
 
-namespace Friendica\Model;
+namespace Friendica\Database\Model;
 
 use Exception;
 use Friendica\Database\DBA;
-use Friendica\Database\Entity\CacheEntity;
+use Friendica\Entity\CacheEntity;
 
 /**
  * Model for a row in the cache table

src/Database/Repository/CacheRepository.php

@@ -1,40 +0,0 @@
-<?php
-
-// Copyright (C) 2010-2024, the Friendica project
-// SPDX-FileCopyrightText: 2010-2024 the Friendica project
-//
-// SPDX-License-Identifier: AGPL-3.0-or-later
-
-declare(strict_types=1);
-
-namespace Friendica\Database\Repository;
-
-use Friendica\Database\DatabaseException;
-use Friendica\Database\Entity\CacheEntity;
-
-/**
- * Interface for a cache repository
- */
-interface CacheRepository
-{
-	/**
-	 * @throws DatabaseException
-	 *
-	 * @return array<string>
-	 */
-	public function getAllKeysValidUntil(string $expires): array;
-
-	/**
-	 * @throws DatabaseException
-	 *
-	 * @return array<string>
-	 */
-	public function getAllKeysValidUntilWithPrefix(string $expires, string $prefix): array;
-
-	/**
-	 * @throws DatabaseException
-	 *
-	 * @return CacheEntity|null
-	 */
-	public function findOneByKeyValidUntil(string $key, string $expires);
-}

src/Database/Repository/CacheTableRepository.php

@@ -0,0 +1,135 @@
+<?php
+
+// Copyright (C) 2010-2024, the Friendica project
+// SPDX-FileCopyrightText: 2010-2024 the Friendica project
+//
+// SPDX-License-Identifier: AGPL-3.0-or-later
+
+declare(strict_types=1);
+
+namespace Friendica\Database\Repository;
+
+use Friendica\Database\Database;
+use Friendica\Database\DatabaseException;
+use Friendica\Database\Model\CacheModel;
+use Friendica\Entity\CacheEntity;
+use Friendica\Repository\CacheRepository;
+use Throwable;
+
+/**
+ * Repository for cache table
+ */
+final class CacheTableRepository implements CacheRepository
+{
+	private Database $database;
+
+	public function __construct(Database $database)
+	{
+		$this->database = $database;
+	}
+
+	/**
+	 * @throws DatabaseException
+	 *
+	 * @return array<string>
+	 */
+	public function getAllKeysValidUntil(string $expires): array
+	{
+		$throw = $this->database->throwExceptionsOnErrors(true);
+
+		try {
+			return $this->getAllKeys($expires, null);
+		} catch (Throwable $th) {
+			if (! $th instanceof DatabaseException) {
+				$th = new DatabaseException('Cannot fetch all keys without prefix', 0, '', $th);
+			}
+
+			throw $th;
+		} finally {
+			$this->database->throwExceptionsOnErrors($throw);
+		}
+	}
+
+	/**
+	 * @throws DatabaseException
+	 *
+	 * @return array<string>
+	 */
+	public function getAllKeysValidUntilWithPrefix(string $expires, string $prefix): array
+	{
+		$throw = $this->database->throwExceptionsOnErrors(true);
+
+		try {
+			return $this->getAllKeys($expires, $prefix);
+		} catch (Throwable $th) {
+			if (! $th instanceof DatabaseException) {
+				$th = new DatabaseException(sprintf('Cannot fetch all keys with prefix `%s`', $prefix), 0, '', $th);
+			}
+
+			throw $th;
+		} finally {
+			$this->database->throwExceptionsOnErrors($throw);
+		}
+	}
+
+	/**
+	 * @throws DatabaseException
+	 *
+	 * @return CacheEntity|null
+	 */
+	public function findOneByKeyValidUntil(string $key, string $expires)
+	{
+		$throw = $this->database->throwExceptionsOnErrors(true);
+
+		try {
+			$cacheArray = $this->database->selectFirst(
+				'cache',
+				['v'],
+				['`k` = ? AND (`expires` >= ? OR `expires` = -1)', $key, $expires]
+			);
+
+			if (!$this->database->isResult($cacheArray)) {
+				return null;
+			}
+		} catch (Throwable $th) {
+			if (! $th instanceof DatabaseException) {
+				$th = new DatabaseException(sprintf('Cannot get cache entry with key `%s`', $key), 0, '', $th);
+			}
+
+			throw $th;
+		} finally {
+			$this->database->throwExceptionsOnErrors($throw);
+		}
+
+		try {
+			$entity = CacheModel::createFromArray($cacheArray);
+		} catch (Throwable $th) {
+			return null;
+		}
+
+		return $entity;
+	}
+
+	private function getAllKeys(string $expires, ?string $prefix = null): array
+	{
+		if ($prefix === null) {
+			$where = ['`expires` >= ?', $expires];
+		} else {
+			$where = ['`expires` >= ? AND `k` LIKE CONCAT(?, \'%\')', $expires, $prefix];
+		}
+
+		$stmt = $this->database->select('cache', ['k'], $where);
+
+		$keys = [];
+
+		try {
+			while ($key = $this->database->fetch($stmt)) {
+				array_push($keys, $key['k']);
+			}
+		} finally {
+			$this->database->close($stmt);
+		}
+
+		return $keys;
+	}
+}

src/Database/Repository/UserdTableRepository.php

@@ -7,17 +7,17 @@
 
 declare(strict_types=1);
 
-namespace Friendica\Repository;
+namespace Friendica\Database\Repository;
 
 use Exception;
 use Friendica\Database\Database;
 use Friendica\Database\DatabaseException;
-use Friendica\Database\Repository\DeletedUserRepository;
+use Friendica\Repository\DeletedUserRepository;
 
 /**
- * Repository for deleted users
+ * Repository for userd table
  */
-final class UserdRepository implements DeletedUserRepository
+final class UserdTableRepository implements DeletedUserRepository
 {
 	private Database $database;
 

src/Entity/CacheEntity.php

@@ -7,10 +7,10 @@
 
 declare(strict_types=1);
 
-namespace Friendica\Database\Entity;
+namespace Friendica\Entity;
 
 /**
- * Entity for a row in the cache table
+ * Entity for a cache entry
  */
 interface CacheEntity
 {

src/Module/Profile/Profile.php

@@ -23,7 +23,6 @@ use Friendica\Core\Renderer;
 use Friendica\Core\Session\Capability\IHandleUserSessions;
 use Friendica\Database\Database;
 use Friendica\Database\DBA;
-use Friendica\Database\Repository\DeletedUserRepository;
 use Friendica\Event\HtmlFilterEvent;
 use Friendica\Model\Contact;
 use Friendica\Model\Profile as ProfileModel;
@@ -36,6 +35,7 @@ use Friendica\Network\HTTPException;
 use Friendica\Network\HTTPException\InternalServerErrorException;
 use Friendica\Profile\ProfileField\Repository\ProfileField;
 use Friendica\Protocol\ActivityPub;
+use Friendica\Repository\DeletedUserRepository;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
 use Friendica\Util\Profiler;

src/Module/User/Import.php

@@ -20,7 +20,6 @@ use Friendica\Core\Worker;
 use Friendica\Database\Database;
 use Friendica\Database\DBA;
 use Friendica\Database\DBStructure;
-use Friendica\Database\Repository\DeletedUserRepository;
 use Friendica\Model\Photo;
 use Friendica\Model\Profile;
 use Friendica\Module\Response;
@@ -28,6 +27,7 @@ use Friendica\Navigation\SystemMessages;
 use Friendica\Network\HTTPException;
 use Friendica\Object\Image;
 use Friendica\Protocol\Delivery;
+use Friendica\Repository\DeletedUserRepository;
 use Friendica\Security\PermissionSet\Repository\PermissionSet;
 use Friendica\Util\Profiler;
 use Friendica\Util\Strings;

src/Repository/CacheRepository.php

@@ -9,127 +9,32 @@ declare(strict_types=1);
 
 namespace Friendica\Repository;
 
-use Friendica\Database\Database;
 use Friendica\Database\DatabaseException;
-use Friendica\Database\Entity\CacheEntity;
+use Friendica\Entity\CacheEntity;
-use Friendica\Database\Repository\CacheRepository as CacheRepositoryInterface;
-use Friendica\Model\CacheModel;
-use Throwable;
 
 /**
- * Repository for cache table
+ * Interface for a cache repository
  */
-final class CacheRepository implements CacheRepositoryInterface
+interface CacheRepository
 {
-	private Database $database;
+	/**
-
+	 * @throws DatabaseException
-	public function __construct(Database $database)
+	 *
-	{
+	 * @return array<string>
-		$this->database = $database;
+	 */
-	}
+	public function getAllKeysValidUntil(string $expires): array;
 
 	/**
 	 * @throws DatabaseException
 	 *
 	 * @return array<string>
 	 */
-	public function getAllKeysValidUntil(string $expires): array
+	public function getAllKeysValidUntilWithPrefix(string $expires, string $prefix): array;
-	{
-		$throw = $this->database->throwExceptionsOnErrors(true);
-
-		try {
-			return $this->getAllKeys($expires, null);
-		} catch (Throwable $th) {
-			if (! $th instanceof DatabaseException) {
-				$th = new DatabaseException('Cannot fetch all keys without prefix', 0, '', $th);
-			}
-
-			throw $th;
-		} finally {
-			$this->database->throwExceptionsOnErrors($throw);
-		}
-	}
-
-	/**
-	 * @throws DatabaseException
-	 *
-	 * @return array<string>
-	 */
-	public function getAllKeysValidUntilWithPrefix(string $expires, string $prefix): array
-	{
-		$throw = $this->database->throwExceptionsOnErrors(true);
-
-		try {
-			return $this->getAllKeys($expires, $prefix);
-		} catch (Throwable $th) {
-			if (! $th instanceof DatabaseException) {
-				$th = new DatabaseException(sprintf('Cannot fetch all keys with prefix `%s`', $prefix), 0, '', $th);
-			}
-
-			throw $th;
-		} finally {
-			$this->database->throwExceptionsOnErrors($throw);
-		}
-	}
 
 	/**
 	 * @throws DatabaseException
 	 *
 	 * @return CacheEntity|null
 	 */
-	public function findOneByKeyValidUntil(string $key, string $expires)
+	public function findOneByKeyValidUntil(string $key, string $expires);
-	{
-		$throw = $this->database->throwExceptionsOnErrors(true);
-
-		try {
-			$cacheArray = $this->database->selectFirst(
-				'cache',
-				['v'],
-				['`k` = ? AND (`expires` >= ? OR `expires` = -1)', $key, $expires]
-			);
-
-			if (!$this->database->isResult($cacheArray)) {
-				return null;
-			}
-		} catch (Throwable $th) {
-			if (! $th instanceof DatabaseException) {
-				$th = new DatabaseException(sprintf('Cannot get cache entry with key `%s`', $key), 0, '', $th);
-			}
-
-			throw $th;
-		} finally {
-			$this->database->throwExceptionsOnErrors($throw);
-		}
-
-		try {
-			$entity = CacheModel::createFromArray($cacheArray);
-		} catch (Throwable $th) {
-			return null;
-		}
-
-		return $entity;
-	}
-
-	private function getAllKeys(string $expires, ?string $prefix = null): array
-	{
-		if ($prefix === null) {
-			$where = ['`expires` >= ?', $expires];
-		} else {
-			$where = ['`expires` >= ? AND `k` LIKE CONCAT(?, \'%\')', $expires, $prefix];
-		}
-
-		$stmt = $this->database->select('cache', ['k'], $where);
-
-		$keys = [];
-
-		try {
-			while ($key = $this->database->fetch($stmt)) {
-				array_push($keys, $key['k']);
-			}
-		} finally {
-			$this->database->close($stmt);
-		}
-
-		return $keys;
-	}
 }

src/Repository/DeletedUserRepository.php

@@ -7,7 +7,7 @@
 
 declare(strict_types=1);
 
-namespace Friendica\Database\Repository;
+namespace Friendica\Repository;
 
 use Exception;
 use Friendica\Database\DatabaseException;

tests/Unit/Database/Repository/CacheTableRepositoryTest.php

@@ -7,15 +7,15 @@
 
 declare(strict_types=1);
 
-namespace Friendica\Test\Unit\Repository;
+namespace Friendica\Test\Unit\Database\Repository;
 
 use Friendica\Database\Database;
 use Friendica\Database\DatabaseException;
-use Friendica\Repository\CacheRepository;
+use Friendica\Database\Repository\CacheTableRepository;
 use PHPUnit\Framework\TestCase;
 use Throwable;
 
-class CacheRepositoryTest extends TestCase
+class CacheTableRepositoryTest extends TestCase
 {
 	public function testGetAllKeysValidUntilReturnsArray(): void
 	{
@@ -32,7 +32,7 @@ class CacheRepositoryTest extends TestCase
 			false
 		);
 
-		$repo = new CacheRepository($database);
+		$repo = new CacheTableRepository($database);
 
 		$this->assertSame(
 			[
@@ -49,7 +49,7 @@ class CacheRepositoryTest extends TestCase
 		$database = $this->createStub(Database::class);
 		$database->method('select')->willThrowException($this->createStub(Throwable::class));
 
-		$repo = new CacheRepository($database);
+		$repo = new CacheTableRepository($database);
 
 		$this->expectException(DatabaseException::class);
 
@@ -71,7 +71,7 @@ class CacheRepositoryTest extends TestCase
 			false
 		);
 
-		$repo = new CacheRepository($database);
+		$repo = new CacheTableRepository($database);
 
 		$this->assertSame(
 			[
@@ -88,7 +88,7 @@ class CacheRepositoryTest extends TestCase
 		$database = $this->createStub(Database::class);
 		$database->method('select')->willThrowException($this->createStub(Throwable::class));
 
-		$repo = new CacheRepository($database);
+		$repo = new CacheTableRepository($database);
 
 		$this->expectException(DatabaseException::class);
 

tests/Unit/Database/Repository/UserdTableRepositoryTest.php

@@ -7,19 +7,19 @@
 
 declare(strict_types=1);
 
-namespace Friendica\Test\Unit\Repository;
+namespace Friendica\Test\Unit\Database\Repository;
 
 use Friendica\Database\Database;
 use Friendica\Database\DatabaseException;
-use Friendica\Database\Repository\DeletedUserRepository;
+use Friendica\Database\Repository\UserdTableRepository;
-use Friendica\Repository\UserdRepository;
+use Friendica\Repository\DeletedUserRepository;
 use PHPUnit\Framework\TestCase;
 
-class UserdRepositoryTest extends TestCase
+class UserdTableRepositoryTest extends TestCase
 {
 	public function testImplementationOfInterfaces(): void
 	{
-		$repo = new UserdRepository($this->createMock(Database::class));
+		$repo = new UserdTableRepository($this->createMock(Database::class));
 
 		$this->assertInstanceOf(DeletedUserRepository::class, $repo);
 	}
@@ -31,7 +31,7 @@ class UserdRepositoryTest extends TestCase
 			['userd', ['username' => 'test'], 0, true],
 		]);
 
-		$repo = new UserdRepository($database);
+		$repo = new UserdTableRepository($database);
 
 		$repo->insertByUsername('test');
 	}
@@ -44,7 +44,7 @@ class UserdRepositoryTest extends TestCase
 			new DatabaseException('An error occured.', 0, 'SQL query')
 		);
 
-		$repo = new UserdRepository($database);
+		$repo = new UserdTableRepository($database);
 
 		$this->expectException(DatabaseException::class);
 
@@ -58,7 +58,7 @@ class UserdRepositoryTest extends TestCase
 			['userd', ['username' => 'test'], true],
 		]);
 
-		$repo = new UserdRepository($database);
+		$repo = new UserdTableRepository($database);
 
 		$this->assertTrue($repo->existsByUsername('test'));
 	}
@@ -70,7 +70,7 @@ class UserdRepositoryTest extends TestCase
 			['userd', ['username' => 'test'], false],
 		]);
 
-		$repo = new UserdRepository($database);
+		$repo = new UserdTableRepository($database);
 
 		$this->assertFalse($repo->existsByUsername('test'));
 	}